Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

03-1125: (bug) fix current visit retaining previous patient visit-data #332

Merged
merged 4 commits into from
Mar 3, 2022
Merged

03-1125: (bug) fix current visit retaining previous patient visit-data #332

merged 4 commits into from
Mar 3, 2022
+73 −77

Conversation

donaldkibet
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests, or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR addresses a number of things

  • remove dependency on rxjs
  • update useVisit hook to fix bug where, on searching a different patient, the previous patient visit data would still be displayed as the patient's visit. This is seen on the active-visit-tag.component on patient chart
  • provide mechanism to pass in current visit. useful when entering retrospective data.

Screenshots

current-visit

Related Issue

https://issues.openmrs.org/projects/MF/issues/O3-1125

Other

@donaldkibet donaldkibet mentioned this pull request Feb 21, 2022
Merged
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2022 •
edited
Loading

File size impact

Merging 03-1125 into master impact files as follow:

@openmrs/esm-devtools-app (+2.31%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 403 kB (+9.67 kB / +2.46%) ↗️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 428 kB (+9.67 kB / +2.31%) ↗️
@openmrs/esm-implementer-tools-app (+0.53%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 403 kB (+9.67 kB / +2.46%) ↗️
Unmodified (16) 1.44 MB (0 B / +0%) 👻
Total (17) 1.85 MB (+9.67 kB / +0.53%) ↗️
@openmrs/esm-login-app (+0.48%)
Files new size
packages/apps/esm-login-app/dist/217.js 403 kB (+9.67 kB / +2.46%) ↗️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 2.01 MB (+9.67 kB / +0.48%) ↗️
@openmrs/esm-offline-tools-app (+0.35%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 403 kB (+9.67 kB / +2.46%) ↗️
Unmodified (25) 2.37 MB (0 B / +0%) 👻
Total (26) 2.77 MB (+9.67 kB / +0.35%) ↗️
@openmrs/esm-primary-navigation-app (+0.45%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 403 kB (+9.67 kB / +2.46%) ↗️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.14 MB (+9.67 kB / +0.45%) ↗️
@openmrs/esm-app-shell (+0.46%)
Files new size
packages/shell/esm-app-shell/dist/openmrs.js 1.41 MB (+9.65 kB / +0.69%) ↗️
packages/shell/esm-app-shell/dist/c6e919635c7485e14f27.js 9.56 kB 👶
packages/shell/esm-app-shell/dist/5a757277b7e94529dead.js deleted (-9.56 kB)
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (0 B / +0%) 👻
Unmodified (1) 528 kB (0 B / +0%) 👻
Total (5) 2.11 MB (+9.65 kB / +0.46%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1928406002 on 3195d77

@github-actions
Copy link
Contributor

File size impact

Merging 03-1125 into master impact files as follow:

@openmrs/esm-devtools-app (+0.14%)
Files new size
packages/apps/esm-devtools-app/dist/217.js 323 kB (+493 B / +0.15%) ↗️
Unmodified (4) 25.2 kB (0 B / +0%) 👻
Total (5) 348 kB (+493 B / +0.14%) ↗️
@openmrs/esm-implementer-tools-app (+0.03%)
Files new size
packages/apps/esm-implementer-tools-app/dist/217.js 323 kB (+493 B / +0.15%) ↗️
Unmodified (16) 1.35 MB (0 B / +0%) 👻
Total (17) 1.67 MB (+493 B / +0.03%) ↗️
@openmrs/esm-login-app (+0.03%)
Files new size
packages/apps/esm-login-app/dist/217.js 323 kB (+493 B / +0.15%) ↗️
Unmodified (27) 1.61 MB (0 B / +0%) 👻
Total (28) 1.93 MB (+493 B / +0.03%) ↗️
@openmrs/esm-offline-tools-app (+0.02%)
Files new size
packages/apps/esm-offline-tools-app/dist/217.js 323 kB (+493 B / +0.15%) ↗️
Unmodified (25) 2.37 MB (0 B / +0%) 👻
Total (26) 2.69 MB (+493 B / +0.02%) ↗️
@openmrs/esm-primary-navigation-app (+0.02%)
Files new size
packages/apps/esm-primary-navigation-app/dist/217.js 323 kB (+493 B / +0.15%) ↗️
Unmodified (17) 1.74 MB (0 B / +0%) 👻
Total (18) 2.06 MB (+493 B / +0.02%) ↗️
@openmrs/esm-app-shell (+0.04%)
Files new size
packages/shell/esm-app-shell/dist/45f72e983203e309938f.js 9.56 kB 👶
packages/shell/esm-app-shell/dist/openmrs.js 1.33 MB (+752 B / +0.06%) ↗️
packages/shell/esm-app-shell/dist/5f21cf2c88a00c062623.js deleted (-9.56 kB)
packages/shell/esm-app-shell/dist/service-worker.js 164 kB (0 B / +0%) 👻
Unmodified (1) 528 kB (0 B / +0%) 👻
Total (5) 2.03 MB (+752 B / +0.04%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#1877961416 on fcb9969

brandones
brandones approved these changes Mar 3, 2022
View reviewed changes
Copy link
Collaborator

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @donaldkibet !

@brandones brandones merged commit 1fc4a42 into master Mar 3, 2022
@brandones brandones deleted the 03-1125 branch March 3, 2022 17:23
@ZacButko ZacButko mentioned this pull request May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen left review comments

@brandones brandones brandones approved these changes

@ZacButko ZacButko Awaiting requested review from ZacButko

@jonathandick jonathandick Awaiting requested review from jonathandick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donaldkibet @brandones @denniskigen